Skip to content

Conversation

@codeatri
Copy link

@codeatri codeatri commented Oct 18, 2020

@soojison
Copy link

Hey CC'ing @sambekar15 also to verify. I think the issue ticket is worded imprecisely which probably is adding to the confusion. If I understand the issue ticket correctly, we want to:

  • return full lineage if no query param is present
  • return full fw lineage if no query param for FW lineage is present
  • return full bw lineage if no query param for BW lineage present

So for instance,
http://localhost:9000/v1/lineage/table/LOREM?bw=0 => return full FW lineage
http://localhost:9000/v1/lineage/table/LOREM?fw=0 => return full BW lineage
http://localhost:9000/v1/lineage/table/LOREM?fw=0&bw=0 => return empty lineage
http://localhost:9000/v1/lineage/table/LOREM?fw=1 => return fw @ depth 1, full BW lineage and so forth, right?

If that's the case, this fix won't achieve what we want to do

@sambekar15
Copy link
Contributor

Hey CC'ing @sambekar15 also to verify. I think the issue ticket is worded imprecisely which probably is adding to the confusion. If I understand the issue ticket correctly, we want to:

* return full lineage if no query param is present

* return full fw lineage if no query param for FW lineage is present

* return full bw lineage if no query param for BW lineage present

So for instance,
http://localhost:9000/v1/lineage/table/LOREM?bw=0 => return full FW lineage
http://localhost:9000/v1/lineage/table/LOREM?fw=0 => return full BW lineage
http://localhost:9000/v1/lineage/table/LOREM?fw=0&bw=0 => return empty lineage
http://localhost:9000/v1/lineage/table/LOREM?fw=1 => return fw @ depth 1, full BW lineage and so forth, right?

If that's the case, this fix won't achieve what we want to do
yeah these conditions are correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lineage API response is incorrect when only of the queryParam (fw or bw) is passed

3 participants