Handle missing PulseAudio socket/cookie #190
Conversation
|
Thanks! Sorry, I forgot about this PR for a little while. Looking into it. Also, Clippy has some suggestions, see failing checks. |
src/main.rs
Outdated
| if !envs.is_empty() { | ||
| envs.extend(prepare_pulseaudio_cookie(ctx)?); | ||
| } else { | ||
| return Ok(envs); |
There was a problem hiding this comment.
Seems weird to me that you've made both the socket and the cookie optional.
So we can get into a state where ego adds permissions to the socket, sets PULSE_SERVER variable, but then fails to handle the cookie, so PulseAudio will be half-configured.
I would use presence of either the socket or the cookie as signal whether PulseAudio should be enabled. If the other part can't be found, then still error out, as something is misconfigured.
Seems it would be as simple as changing the detection logic above ...
let path = ctx.runtime_dir.join("pulse");
if !path.is_dir() {... to check existence of the socket /run/user/1000/pulse/native, not the directory /run/user/1000/pulse as it does now.
Unless you see any downsides with this approach?
There was a problem hiding this comment.
I made only socket optional in latest commit
2 participants
fix #189