TKT-9214: Add Code Reuse by Block #160
Conversation
davidt99
left a comment
davidt99
left a comment
There was a problem hiding this comment.
Missing version bump and changes update
intezer_sdk/code_reuse.py
Outdated
There was a problem hiding this comment.
There is a File object, put the logic there
There was a problem hiding this comment.
The FileAnalysis(Analysis) class doesn't look like the right place to put this logic because the behavior of the endpoint is different. This endpoint directly takes a sha256 and doesn't need to lookup the latest analysis. If it needs to be part of that class, it is best implemented as a classmethod. Would that be your recommendation?
intezer_sdk/code_reuse.py
Outdated
| def __init__(self, api_client: Optional[IntezerApiClient] = None): | ||
| self._api = IntezerApi(api_client or api.get_global_api()) | ||
|
|
||
| def _get_result_from_task(self, result_url: str): |
There was a problem hiding this comment.
The logic is most likely already implemented
There was a problem hiding this comment.
The endpoint doesn't return the required json data for the check_status method to be used. The wait logic has to be checked using the HTTP status code.
joakim-intezer
force-pushed
the
feature/code_reuse_by_block
branch
from
1f6e43d to
1b265c2
Compare
- Format import statements - Use @DataClass for Block class - Make is_common a property - Switch from " strings to ' strings - Use of HTTPStatus instead of int - Changed variable format to long-name
davidt99
force-pushed
the
feature/code_reuse_by_block
branch
from
2193bd6 to
34af90a
Compare
No description provided.