[PB-4948]: fix/allow uploading empty files #1782
Draft
+498
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying drive-web with
|
| Latest commit: |
9d2aa18
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5b412906.drive-web.pages.dev |
| Branch Preview URL: | https://feature-upload-empty-files.drive-web.pages.dev |
CandelR
approved these changes
Dec 23, 2025
Comment on lines
+48
to
+50
| if (!fileId) { | ||
| throw new FileIdRequiredError(); | ||
| } |
Collaborator
There was a problem hiding this comment.
I left this comment in order to check if the upload of empty files are already implemented in backend for workspaces in order to remove this check
|
|
||
| const isWorkspacesUpload = workspaceId && workspacesToken; | ||
|
|
||
| if (isFileEmpty(file.content) && !isWorkspacesUpload) { |
Collaborator
There was a problem hiding this comment.
I left this comment in order to check if the upload of empty files are already implemented in backend for workspaces to remove this condition && !isWorkspacesUpload
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the user to create empty files.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes
The status of this PR has been updated back to “Draft” because we must wait for the other platforms to allow empty files to upload/download empty files, but the request can be reviewed in the meantime so that it can be implemented when necessary.