Skip to content

Conversation

@terrerox
Copy link
Contributor

Description

  • Update @internxt/sdk to 1.11.21 for improved version history support
  • Add batch delete functionality for multiple version selections
  • Implement version limits display showing used/total allowed versions
  • Fix file replace operation to properly upload new file content
  • Migrate from local FileVersion type to SDK types for better consistency
  • Add indeterminate checkbox state for partial selections
  • Improve version restoration to update current version state
  • Enhance skeleton loading to show more realistic version count
  • Add getLimits API call to fetch version constraints
  • Refactor CurrentVersionItem to use version info instead of full item data

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Additional Notes

…ration

  - Update @internxt/sdk to 1.11.21 for improved version history support
  - Add batch delete functionality for multiple version selections
  - Implement version limits display showing used/total allowed versions
  - Fix file replace operation to properly upload new file content
  - Migrate from local FileVersion type to SDK types for better consistency
  - Add indeterminate checkbox state for partial selections
  - Improve version restoration to update current version state
  - Enhance skeleton loading to show more realistic version count
  - Add getLimits API call to fetch version constraints
  - Refactor CurrentVersionItem to use version info instead of full item data
});
} else {
const file = itemToUpload as File;
const { bridgeUser, bridgePass, encryptionKey, bucketId } = getEnvironmentConfig(!!selectedWorkspace);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed a way to upload the file content without creating the database entry in order to avoid the ‘this file exists’ error. This is the most efficient approach I found, but feel free to suggest any improvements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's leave it here, but can you extract it to a function so that if we decide to move it somewhere else, we already have the logic encapsulated?

@terrerox terrerox force-pushed the feature/file-version-history-v3 branch from 7630a19 to f3a74ba Compare December 12, 2025 05:56
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 12, 2025

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0278fd6
Status:🚫  Build failed.

View logs

@terrerox
Copy link
Contributor Author

Quality Gate Failed Quality Gate failed

Failed conditions 0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Tests will be added in a separate PR

Copy link
Contributor

@xabg2 xabg2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job man! 🚀

<>
<CurrentVersionItem key={item.id} version={item} userName={userName} />
<CurrentVersionItem
key={currentVersion?.id ?? item.id}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract this to a variable.

<CurrentVersionItem key={item.id} version={item} userName={userName} />
<CurrentVersionItem
key={currentVersion?.id ?? item.id}
createdAt={currentVersion?.createdAt ?? item.createdAt}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

<AutosaveSection
totalAutosaveCount={totalAutosaveCount}
totalVersionsCount={totalVersionsCount}
totalAllowedVersions={limits?.versioning.maxVersions ?? 0}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

@terrerox terrerox self-assigned this Dec 12, 2025
@terrerox terrerox requested a review from xabg2 December 12, 2025 15:50
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants