[PB-5465] Implement file version history actions #1771

terrerox · 2025-12-09T03:26:43Z

Description

Add version download, delete, and restore functionality
Implement file version service with API integration
Add version action dialogs for delete and restore confirmations
Add loading skeleton component for version history sidebar
Replace mock data with real API integration
Add UI state management for version dialogs
Pass userName prop to version components to avoid duplication
Update name collision dialog to use replaceFile endpoint instead of delete-and-reupload
Add replace-file service for efficient file replacement
Upgrade @internxt/sdk from 1.11.17 to 1.11.18

Related Issues

Related Pull Requests

Checklist

Changes have been tested locally.
Unit tests have been written or updated as necessary.
The code adheres to the repository's coding standards.
Relevant documentation has been added or updated.
No new warnings or errors have been introduced.
SonarCloud issues have been reviewed and addressed.
QA Passed

Testing Process

Additional Notes

cloudflare-workers-and-pages · 2025-12-09T03:30:26Z

Deploying drive-web with Cloudflare Pages

Latest commit:	`da946c8`
Status:	🚫 Build failed.

View logs

…wnload functionality Adds complete file version management system with API integration for viewing, restoring, deleting, and downloading file versions. Updates name collision dialog to use replaceFile endpoint instead of delete-and-reupload for file replacements.

…itional messages and error handling

terrerox · 2025-12-10T05:06:53Z

src/app/i18n/locales/en.json

      "restoreVersion": "Restore version",
      "downloadVersion": "Download version",
-      "deleteVersion": "Delete version"
+      "deleteVersion": "Delete version",


The remaining translations are included in this PR: #1773

…ability

xabg2 · 2025-12-10T08:26:30Z

src/views/Drive/components/VersionHistory/services/file-version.service.ts

+  const user = localStorageService.getUser();
+  if (!user) throw new Error('User not found');
+
+  const fileStream = await downloadFile({


Can we use the multipart download for this? Imagine the file has 5GB or more. It would be better to download it in parallel-small chunks instead of the full file at once. You can do it by using the DownloadManager.downloadItem if I'm not mistaken.

Check that as we need to download the items using the actual method since it solves a lot of speed/memory issues.

xabg2 · 2025-12-10T08:29:20Z

src/views/Drive/components/VersionHistory/services/fileVersion.service.ts

Remember to add tests to this service.

xabg2 · 2025-12-10T08:29:56Z

src/views/Drive/components/VersionHistory/services/file-version.service.ts

+    },
+  });
+
+  const blob = await binaryStreamToBlob(fileStream);


Downloading it as blob and then save it will causes memory issues, specially for Firefox. Also, it won't work for big files in Safari - the file will be downloaded but only 700 bytes (or even 0) will be saved to the disk as Safari does not allow saving big blobs.

Try the method I mentioned above as it already handles all these things, such as saving the downloaded + decrypted chunk directly to the user disk instead of saving it in memory

xabg2 · 2025-12-10T08:32:08Z

src/views/Drive/services/replaceFile.service.ts

Why is this function in this service? It is a part of file versioning, isn't it? Also, remember to add tests to this service.

This service is used in the name-collision modal, which belongs to Drive and isn’t necessarily part of the file-version history flow. That’s why I placed it inside the Drive module. It could live under Version History as well, but keeping it in Drive makes more sense in this context. What do you think?

The tests will be added in a separate PR.

…etter UX - Replace direct download with DownloadManager for efficient multipart downloads - Add workspace credentials support for version downloads - Position TaskLogger at bottom-right - Refactor: rename service files to camelCase convention (file-version.service.ts → fileVersion.service.ts, replace-file.service.ts → replaceFile.service.ts) - Pass file item and workspace context to downloadVersion for proper credential handling

….lock

Remove try-catch block and error handling from useVersionItemActions since DownloadManager already handles error reporting, notifications, and task status updates internally. This prevents duplicate error notifications from being shown to the user.

[PB-5465]: enhance internationalization for version management

sonarqubecloud · 2025-12-10T19:40:50Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

larryrider · 2025-12-18T10:28:32Z

yarn.lock

-  integrity sha512-91iEUvZizlwX6KBEFJ3JdFiGrhMBQ9R54sTc3Pei9QtV2FYTU8nTVEPYAg39tLOGzT/kVuplYOtBxfk6wFtSDA==
+"@internxt/sdk@1.11.19":
+  version "1.11.19"
+  resolved "https://npm.pkg.github.com/download/@internxt/sdk/1.11.19/f9033c8bf0849d414a3865806bacd79026a38769#f9033c8bf0849d414a3865806bacd79026a38769"


This change is breaking your cloudflare build, and it also breaking the PR's that depend on this one. You are using an .npmrc file so you are changing the internxt registry from yarnpkg to github.

You should use this one:

registry=https://registry.yarnpkg.com/
@internxt:registry=https://registry.yarnpkg.com/

Thanks! Since this is an old PR, I made the change in this one instead: #1779

terrerox requested review from CandelR, larryrider and xabg2 as code owners December 9, 2025 03:26

terrerox marked this pull request as draft December 9, 2025 03:26

terrerox self-assigned this Dec 9, 2025

terrerox force-pushed the feature/file-version-history-v2 branch from 0fc701b to 1612aff Compare December 10, 2025 04:55

feature: enhance internationalization for version management with add…

4a2ab35

…itional messages and error handling

terrerox marked this pull request as ready for review December 10, 2025 05:04

terrerox commented Dec 10, 2025

View reviewed changes

refactor: update skeleton component to use Array.from for better read…

f59d219

…ability

terrerox force-pushed the feature/file-version-history-v2 branch from 48361a6 to f59d219 Compare December 10, 2025 05:31

xabg2 requested changes Dec 10, 2025

View reviewed changes

terrerox requested a review from xabg2 December 10, 2025 15:00

fix: update @internxt/sdk version to 1.11.19 in package.json and yarn…

7195005

….lock

xabg2 approved these changes Dec 10, 2025

View reviewed changes

terrerox and others added 2 commits December 10, 2025 11:21

Merge pull request #1773 from internxt/feature/file-version-history-v3

da946c8

[PB-5465]: enhance internationalization for version management

larryrider requested changes Dec 18, 2025

View reviewed changes

terrerox requested a review from larryrider December 18, 2025 13:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PB-5465] Implement file version history actions #1771

[PB-5465] Implement file version history actions #1771

terrerox commented Dec 9, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

terrerox Dec 10, 2025

Uh oh!

xabg2 Dec 10, 2025

Uh oh!

xabg2 Dec 10, 2025

Uh oh!

xabg2 Dec 10, 2025 •

edited

Loading

Uh oh!

xabg2 Dec 10, 2025

Uh oh!

terrerox Dec 10, 2025

Uh oh!

sonarqubecloud bot commented Dec 10, 2025

Uh oh!

larryrider Dec 18, 2025 •

edited

Loading

Uh oh!

terrerox Dec 18, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[PB-5465] Implement file version history actions #1771

Are you sure you want to change the base?

[PB-5465] Implement file version history actions #1771

Conversation

terrerox commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Related Pull Requests

Checklist

Testing Process

Additional Notes

Uh oh!

cloudflare-workers-and-pages bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying drive-web with Cloudflare Pages

Uh oh!

terrerox Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

xabg2 Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

xabg2 Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

xabg2 Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xabg2 Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

terrerox Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Dec 10, 2025

Quality Gate failed

Uh oh!

larryrider Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

terrerox Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

terrerox commented Dec 9, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 9, 2025 •

edited

Loading

xabg2 Dec 10, 2025 •

edited

Loading

larryrider Dec 18, 2025 •

edited

Loading

terrerox Dec 18, 2025 •

edited

Loading