Use CompositeResource everywhere for handling revisit records#122
Open
kngenie wants to merge 1 commit intointernetarchive:masterfrom
Open
Use CompositeResource everywhere for handling revisit records#122kngenie wants to merge 1 commit intointernetarchive:masterfrom
kngenie wants to merge 1 commit intointernetarchive:masterfrom
Conversation
- added getContentEncoding() method to Resource for reading Content-Encoding header from the original - made one-resource version of ReplayRenderer.renderResource() method the primary, rewrite all invocations, and deprecate all two-resource version.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been still using old code passing Resources for revisit record and original capture separately. This patch converges on use of CompositeResource for all revisit cases.
Old methods taking two Resources are kept for backward compatibility (marked deprecated).