controller: evict closed sockets from active_requests #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdempsey
requested changes
Jan 7, 2026
adam-miller
approved these changes
Jan 7, 2026
mistydemeo
force-pushed
the
misty/evict_closed_sockets
branch
from
2d66801 to
2985c26
Compare
avdempsey
approved these changes
Jan 7, 2026
mistydemeo
force-pushed
the
misty/evict_closed_sockets
branch
from
2985c26 to
06d1ee9
Compare
We've noticed closed sockets sticking around in the active_requests dictionary; we think this could be contributing to the incidence of brozzler thinking that requests are still stuck. This commit tries to fix that by forcibly evicting closed sockets from the dict while calculating its status.
mistydemeo
force-pushed
the
misty/evict_closed_sockets
branch
from
06d1ee9 to
b5c8427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed closed sockets sticking around in the
active_requestsdictionary; we think this could be contributing to the incidence of brozzler thinking that requests are still stuck. This commit tries to fix that by forcibly evicting closed sockets from the dict while calculating its status.I've also added details about the open socket, if any, to the status information we return.