active_requests: pop request on pool exceptions #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-miller
reviewed
Jan 7, 2026
mistydemeo
force-pushed
the
misty/pop_request_on_exception
branch
from
78c021c to
5d256db
Compare
If we encounter an exception while trying to submit a job to the thread pool executor, we could hypothetically leave the request dangling in the active_requests dictionary - since we add it to the dictionary before submitting, and rely on popping it back out when the request completes.
mistydemeo
force-pushed
the
misty/pop_request_on_exception
branch
from
5d256db to
1349d4f
Compare
adam-miller
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we encounter an exception while trying to submit a job to the thread pool executor, we could hypothetically leave the request dangling in the active_requests dictionary - since we add it to the dictionary before submitting, and rely on popping it back out when the request completes.