More stable handling of started browsers#74
Open
blekinge wants to merge 1 commit intointernetarchive:masterfrom
Open
More stable handling of started browsers#74blekinge wants to merge 1 commit intointernetarchive:masterfrom
blekinge wants to merge 1 commit intointernetarchive:masterfrom
Conversation
Contributor
|
Sorry for the delay getting to these pull requests by the way. Can you talk about the impetus for this change? What went wrong? Do you have a stack trace? How are you using umbra? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked the starting and stopping of browsers to hopefully make the code more resistant to browser errors.
The major change is in
def browse_thread_run_then_cleanup():
where I open and close+release the resources (browser) the thread needs. By trusting in the try...finally construct, I can ensure that the browser is stopped and released when the thread completes.