Include URL in BrowserThread name, so it will be part of every log li…#72
Open
blekinge wants to merge 1 commit intointernetarchive:masterfrom
Open
Include URL in BrowserThread name, so it will be part of every log li…#72blekinge wants to merge 1 commit intointernetarchive:masterfrom
blekinge wants to merge 1 commit intointernetarchive:masterfrom
Conversation
…ne from Browser thread. Thus, do not log it explicitly
Contributor
|
Url can be very very long. It's too much I think. It's pretty easy to track a url in the logs by grepping for the browser port as you point out. The url is logged on a line like this: Then all the subsequent lines with :35490 are about that url. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the URL in the browserthread name, so it will be logged explicitly.
As it seems that each browserthread is created to handle exactly one URL, having both the URL and the chrome port name as part of the thread name makes sense. And for debugging, it is a LOT easier to read the logs