Open
Conversation
nlevitt
reviewed
May 16, 2019
|
|
||
| logging.basicConfig(stream=sys.stdout, level=args.log_level, | ||
| if (args.log_config_file is not None): | ||
| print(os.path.abspath(args.log_config_file)) |
Contributor
There was a problem hiding this comment.
Something like this would be more friendly:
print("configuring logging from %s" % os.path.abspath(args.log_config_file))
Contributor
|
Is logging.conf meant to be just an example? Maybe call it example-logging.conf then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple change that allows you to specify a logconfig file as a command line param to umbra, rather than having the log config hardcoded