Skip to content

use pagination model for mybooks #11931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RayBB merged 1 commit into from
Feb 25, 2026
Merged

use pagination model for mybooks #11931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions openlibrary/fastapi/public_my_books.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
AuthenticatedUser,
get_authenticated_user,
)
from openlibrary.fastapi.models import Pagination # noqa: TC001
from openlibrary.plugins.upstream.mybooks import ReadingLog
from openlibrary.utils.request_context import site

Expand Down Expand Up @@ -57,8 +58,7 @@ async def get_public_my_books_json(
username: str,
key: ReadingLogKey,
logged_in_user: Annotated[AuthenticatedUser | None, Depends(get_authenticated_user)],
page: int = Query(1, ge=1),
limit: int = Query(100, ge=1, le=1000),
pagination: Annotated[Pagination, Depends()],
q: str = Query("", min_length=0, max_length=100),
mode: str = Query("everything"),
) -> ReadingLogResponse:
Expand Down Expand Up @@ -98,8 +98,9 @@ async def get_public_my_books_json(

fq = [f"ebook_access:[{get_fulltext_min()} TO *]"]

page = pagination.page or 1
readlog = ReadingLog(user=user_obj)
books = readlog.get_works(key, page, limit, q=q, fq=fq).docs
books = readlog.get_works(key, page, pagination.limit, q=q, fq=fq).docs

records_json = [
ReadingLogEntry(
Expand All @@ -120,7 +121,7 @@ async def get_public_my_books_json(
for w in books
]

if page == 1 and len(records_json) < limit:
if page == 1 and len(records_json) < pagination.limit:
num_found = len(records_json)
else:
num_found = readlog.count_shelf(key)
Expand Down