refactor: Use css part for ol-read-more button styling#11817
Open
lokesh wants to merge 4 commits intointernetarchive:masterfrom
Open
refactor: Use css part for ol-read-more button styling#11817lokesh wants to merge 4 commits intointernetarchive:masterfrom
lokesh wants to merge 4 commits intointernetarchive:masterfrom
Conversation
…update styles - Removed the padding-left property from the OLReadMore component to simplify its API. - Updated the component's internal logic and styles accordingly. - Adjusted usage in SearchResultsWork.html to reflect the removal of the padding-left attribute. - Enhanced CSS to apply padding-left through the toggle button part for better responsiveness.
…More component - Updated padding for the toggle button in the OLReadMore component for better alignment. - Added a media query to align the toggle button text to the left on larger screens, enhancing responsiveness.
- Adjusted padding for the toggle button to enhance visual alignment. - Updated media query to reset padding-left for better responsiveness on larger screens.
lokesh
added
the
Theme: Design
lokesh
force-pushed
the
refactor/read-more-css-part
branch
from
0f2962e to
8dc8069
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the clunky padding-left property with a CSS ::part selector for styling.
Technical
Testing
Confirm that visual rendering is unchanged on Book page and Search Results w/Table of Contents that span more than 3 lines.
Screenshot
Stakeholders
@cdrini