migrate several partials components to FastAPI#11773
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Technical
Migrates several partials but not all because some tricky work is needed to get auth working still.
Migrated:
In a followup PR we will migrate the components.
This is because they are either behind auth or will have other tricky bits.
Testing
There are some test files in there that need to be deleted before merging. Just shows that the endpoint are in sync.
AffiliateLinksPartial
BookPageListsPartial
FullTextSuggestionsPartial
SearchFacetsPartial
Screenshot
Stakeholders