Skip to content

Conversation

@devBitt
Copy link

@devBitt devBitt commented Sep 9, 2025

  • Updated xmltramp to be compatible with Python 3.
  • Rewrote onix-import.py to correctly read and parse ONIX XML files.
  • Added sample.xml for testing XML parsing.
  • Fixed import and module path issues for local development.
  • Verified successful parsing of ONIX XML files.

@devBitt devBitt force-pushed the main branch 3 times, most recently from 4fab0b2 to f5fa16d Compare September 9, 2025 12:58
@devBitt
Copy link
Author

devBitt commented Sep 9, 2025

@cclauss
can anyone help me with the ruff (legacy alias)

  • hook id: ruff
  • exit code: 1

@cclauss
Copy link
Contributor

cclauss commented Sep 11, 2025

The ruff legacy alias warning can be fixed by changing this line.

- id: ruff # See pyproject.toml for args

-      - id: ruff  # See pyproject.toml for args
+      - id: ruff-check  # See pyproject.toml for args

I would strongly recommend proposing changes to .pre-commit-config.yaml in a separate pull request from the changes for Fix XML parsing and ONIX import workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants