Skip to content
This repository was archived by the owner on Sep 5, 2025. It is now read-only.

Conversation

@drewda
Copy link
Member

@drewda drewda commented Aug 25, 2025

No description provided.

@drewda drewda requested a review from Copilot August 25, 2025 21:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Improves fallback week selection logic to prioritize weeks with service on all days of the week over partial weeks that may have zero service on certain days. This addresses an issue where weeks with incomplete service patterns (e.g., no Monday/Tuesday service) were being selected as fallback weeks.

  • Modified fallback week selection to use a two-pass algorithm that first seeks weeks with full service, then falls back to highest total service if none exist
  • Added comprehensive test coverage for various edge cases including partial weeks, complete zero-service weeks, and reduced service scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
internal/clock/swcache.go Implements two-pass fallback week selection algorithm with individual day service checks
internal/clock/swcache_test.go Comprehensive test suite covering edge cases for fallback week selection logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants