ci: replace autobuild with manual harness build and multilib deps #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR replaces the CodeQL autobuild action with a manual build process for the harness component. The change adds explicit installation of build dependencies including multilib support before running a custom build script.
Changes:
- Removed the CodeQL autobuild step
- Added manual installation of build dependencies (compilers and multilib packages)
- Configured manual harness build using build.sh script
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| gcc-multilib libc6-dev-i386 | ||
|
|
||
| - name: Build harness (manual for CodeQL) | ||
| run: | |
There was a problem hiding this comment.
The build step lacks error handling and doesn't validate the build script exists. Consider adding a check for build.sh existence or making the script executable if needed.
Suggested change
| run: | | |
| run: | | |
| set -euo pipefail | |
| if [ ! -f build.sh ]; then | |
| echo "Error: build.sh not found in $(pwd)" >&2 | |
| exit 1 | |
| fi | |
| if [ ! -x build.sh ]; then | |
| if ! chmod +x build.sh; then | |
| echo "Error: failed to make build.sh executable" >&2 | |
| exit 1 | |
| fi | |
| fi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.