Skip to content

[SYCL][NFC] Fix copy instead of move Coverity hits #20876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sergey-semenov wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[SYCL][NFC] Fix copy instead of move Coverity hits #20876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/source/detail/queue_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ EventImplPtr queue_impl::submit_graph_direct_impl(
detail::CGType::ExecCommandBuffer),
/*SchedulerBypass*/ false};
} else {
return ExecGraph->enqueue(*this, CGData, EventNeeded);
return ExecGraph->enqueue(*this, std::move(CGData), EventNeeded);
}
};
// If the graph contains a host task, we may need to insert a barrier prior
Expand Down
4 changes: 2 additions & 2 deletions sycl/source/detail/queue_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ class queue_impl : public std::enable_shared_from_this<queue_impl> {
ExecGraph,
sycl::span<const event> DepEvents, const detail::code_location &CodeLoc,
bool IsTopCodeLoc) {
submit_graph_direct_impl(ExecGraph, false, DepEvents, CodeLoc,
submit_graph_direct_impl(std::move(ExecGraph), false, DepEvents, CodeLoc,
IsTopCodeLoc);
}

Expand All @@ -391,7 +391,7 @@ class queue_impl : public std::enable_shared_from_this<queue_impl> {
sycl::span<const event> DepEvents, const detail::code_location &CodeLoc,
bool IsTopCodeLoc) {
return createSyclObjFromImpl<event>(submit_graph_direct_impl(
ExecGraph, true, DepEvents, CodeLoc, IsTopCodeLoc));
std::move(ExecGraph), true, DepEvents, CodeLoc, IsTopCodeLoc));
}

void submit_without_event(const detail::type_erased_cgfo_ty &CGF,
Expand Down