Skip to content

[NFC][libclc] Fix coverity issue: Creating temporary of type llvm::SmallDenseMap ...(TypeReplacements) #20875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wenju-he wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[NFC][libclc] Fix coverity issue: Creating temporary of type llvm::SmallDenseMap ...(TypeReplacements) #20875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions libclc/utils/libclc-remangler/LibclcRemangler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ using Demangler = ManglingParser<DefaultAllocator>;
class Remangler {
public:
Remangler(ASTContext *AST, const Node *Root,
SmallDenseMap<const char *, const char *> TypeReplacements)
const SmallDenseMap<const char *, const char *> &TypeReplacements)
: AST(AST), Root(Root), TypeReplacements(TypeReplacements) {
MangleContext.reset(
ItaniumMangleContext::create(*AST, AST->getDiagnostics()));
Expand Down Expand Up @@ -728,7 +728,7 @@ class Remangler {
ASTContext *AST = nullptr;
std::unique_ptr<clang::MangleContext> MangleContext{};
const Node *Root = nullptr;
SmallDenseMap<const char *, const char *> TypeReplacements{};
const SmallDenseMap<const char *, const char *> &TypeReplacements;

bool Failed = false;

Expand Down Expand Up @@ -790,16 +790,18 @@ class TargetTypeReplacements {
createRemangledTypeReplacements();
}

SmallDenseMap<const char *, const char *> getParameterTypeReplacements() {
const SmallDenseMap<const char *, const char *> &
getParameterTypeReplacements() const {
return ParameterTypeReplacements;
}

SmallDenseMap<const char *, const char *> getCloneTypeReplacements() {
const SmallDenseMap<const char *, const char *> &
getCloneTypeReplacements() const {
return CloneTypeReplacements;
}

SmallDenseMap<const char *, const char *>
getRemangledCloneTypeReplacements() {
const SmallDenseMap<const char *, const char *> &
getRemangledCloneTypeReplacements() const {
return RemangledCloneTypeReplacements;
}
};
Expand Down Expand Up @@ -841,11 +843,11 @@ class LibCLCRemangler : public ASTConsumer {
Replacements.getRemangledCloneTypeReplacements());
}

bool
createCloneFromMap(llvm::Module *M, StringRef OriginalName,
const itanium_demangle::Node *FunctionTree,
SmallDenseMap<const char *, const char *> TypeReplacements,
bool CloneeTypeReplacement = false) {
bool createCloneFromMap(
llvm::Module *M, StringRef OriginalName,
const itanium_demangle::Node *FunctionTree,
const SmallDenseMap<const char *, const char *> &TypeReplacements,
bool CloneeTypeReplacement = false) {
Remangler ATR{ASTCtx, FunctionTree, TypeReplacements};

std::string const RemangledName = ATR.remangle();
Expand Down
Loading