-
Notifications
You must be signed in to change notification settings - Fork 22
Vlmmetrics #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vlmmetrics #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces VLM (Vision Language Model) metrics logging capabilities to the performance tools, enabling tracking of application timing events and performance metrics for VLM workloads.
- Adds a new
VLMMetricsLoggerclass for logging application lifecycle events and VLM performance metrics to rotating log files - Updates the metrics consolidation script to parse and extract statistics from VLM application and performance log files
- Changes the Trivy security scan workflow to output results as a table artifact instead of uploading to GitHub Security tab
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| benchmark-scripts/vlm_metrics_logger.py | Implements the core VLM metrics logging functionality with separate loggers for application events and performance metrics |
| benchmark-scripts/setup.py | Adds setuptools configuration for the vlm_metrics package |
| benchmark-scripts/consolidate_multiple_run_of_metrics.py | Adds two new extractors to parse VLM application metrics and performance metrics from log files |
| .github/workflows/trivyimagescan.yaml | Modifies Trivy scan to generate table format output as an artifact instead of SARIF format for security tab |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
d0caa64
PR Checklist
What are you changing?
Issue this PR will close
close: #issue_number
Anything the reviewer should know when reviewing this PR?
Test Instructions if applicable
If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/performance-tools )