Skip to content

Conversation

@sumanaga
Copy link
Contributor

@sumanaga sumanaga commented Dec 3, 2025

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/performance-tools/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Issue this PR will close

close: #issue_number

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/performance-tools )

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces VLM (Vision Language Model) metrics logging capabilities to the performance tools, enabling tracking of application timing events and performance metrics for VLM workloads.

  • Adds a new VLMMetricsLogger class for logging application lifecycle events and VLM performance metrics to rotating log files
  • Updates the metrics consolidation script to parse and extract statistics from VLM application and performance log files
  • Changes the Trivy security scan workflow to output results as a table artifact instead of uploading to GitHub Security tab

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
benchmark-scripts/vlm_metrics_logger.py Implements the core VLM metrics logging functionality with separate loggers for application events and performance metrics
benchmark-scripts/setup.py Adds setuptools configuration for the vlm_metrics package
benchmark-scripts/consolidate_multiple_run_of_metrics.py Adds two new extractors to parse VLM application metrics and performance metrics from log files
.github/workflows/trivyimagescan.yaml Modifies Trivy scan to generate table format output as an artifact instead of SARIF format for security tab

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
avinash-palleti
avinash-palleti previously approved these changes Dec 3, 2025
sachinkaushik
sachinkaushik previously approved these changes Dec 4, 2025
@sumanaga sumanaga dismissed stale reviews from sachinkaushik and avinash-palleti via d0caa64 January 6, 2026 04:53
@avinash-palleti avinash-palleti merged commit 215d354 into intel-retail:main Jan 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants