-
Notifications
You must be signed in to change notification settings - Fork 17
refactor: migrate docs of individual services to documentations repo #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… a Services section under Automated Self Checkout in Documentation Repo - created section `Services` under Use Cases/Automated Self Checkout - renamed the files based on the service (common-service, pipeline-server, retail-data-visualization) - updated the mkdocs.yml with the new files under a section called Services - ensured that visualization works for docs Issue (intel-retail#51)[intel-retail#51] Co-authored-by: Voon Yong Shing <yong.shing.voon@intel.com> Signed-off-by: Tan Yan Xue <yan.xue.tan@intel.com> Signed-off-by: Ong Jing Hong <jing.hong.ong@intel.com> Signed-off-by: Marcus Khaw Chin Rui <marcus.chin.rui.khaw@intel.com> Signed-off-by: Low Yu Zhe <yu.zhe.low@intel.com>
|
cleaned up commits in this new PR |
ejlee3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NeethuESim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we grab the latest file from the repository - some things changed from a PR that was merged from the OSS hackathon in the common-service.md and retail-data-visualization.md was removed as well.
Removing Retail Data Visualization Markdown due to its removal on other PR
Removal of Retail Data Visualization documentation due to its removal on PR: intel-retail/automated-self-checkout#684
Modified common-service.md as PR: intel-retail/automated-self-checkout#684 has modifications
|
@francis-tanyx are the changes suggested by @ejlee3 incorporated in this PR. We need to merge this first & then the PR - intel-retail/automated-self-checkout#704 |
bc3cca0
Yes I confirm the changes are done,
unsure if the contents in retail-data-visualization.md is migrated |
PR Checklist
What requirement is this design document for?
#Issue #51
Anything the reviewer should know when reviewing this PR?
pipeline-server.mdas it did not originally had anyretail-data-visualization.mdas it did not originally had anyIf there are any other design Pull Requests or requirements, please link them here (i.e. intel-retail/automated-self-checkout )
intel-retail/automated-self-checkout#677