Minimal support for Lakeshore Model 336 cryogenic temperature controller #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 93 94 +1
Lines 9545 9561 +16
=======================================
+ Hits 9468 9484 +16
Misses 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
looks good! I don't know why codecov is complaining about coverage here, a quick look indicates to me that those "missing lines" are indeed covered by your tests 🤔 |
Contributor
Author
|
actually, they are not... copy,paste error in the tests. sorry... |
Contributor
|
HA! |
scasagrande
approved these changes
Jul 4, 2025
Contributor
Author
yeah, codecov did the right thing and I didn't. good it's there |
Contributor
Author
|
Thanks @scasagrande |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily copied from Lakeshore340 class and provides the same functionality for the Model 336. Communications seem different as well as channel addressing.
At the moment, there's only reading the temperatures of the four input channels implemented and no other functionality (reason: that's really all I need for now).
One thing: since this device requires odd parity and bitsize 7, these arguments are now forwarded as
**kwargsto the serial manager and from there topyserialwhen opening the connection.LMK if you have a wishlist for further commands to be implemented or if somebody has a whish. As the device is here, I'd be happy to implement and test further if need be :) Figured I submit this in a barebones state as it initializes the comms and can also serve as a base for future extension.