[v12] feat(ui-popover): rework Popover

docs/guides/upgrade-guide.md

@@ -192,6 +192,7 @@ type: example
 - theme variable `colorError` has been renamed to `errorTextColor`
 - theme variable `colorSuccess` has been renamed to `successTextColor`
 - theme variable `errorIconMarginRight` is now removed
+- `newError` message type is now deprecated. Both `newError` and the original `error` type now behave identically (using the new implementation that was previously exclusive to `newError`)
 
 ### FormFieldMessages
 
@@ -233,6 +234,7 @@ type: example
 - theme variable `focusOutlineColor` is now removed
 - theme variable `requiredInvalidColor` is now removed
 - `error` or `success` messages are no longer displayed when the component is `readOnly` or `disabled`
+- `newError` message type is now deprecated. Both `newError` and the original `error` type now behave identically (using the new implementation that was previously exclusive to `newError`)
 
 ### NumberInput
 
@@ -250,16 +252,19 @@ type: example
 - theme variable `focusOutlineColor` is now removed
 - theme variable `requiredInvalidColor` is now removed
 - `error` or `success` messages are no longer displayed when the component is '`readOnly` or `disabled`
+- `newError` message type is now deprecated. Both `newError` and the original `error` type now behave identically (using the new implementation that was previously exclusive to `newError`)
 
 ### RadioInputGroup
 
 - theme variable `invalidAsteriskColor` is now removed
 - `error` or `success` messages are no longer displayed when the component is '`readOnly` or `disabled`
+- `newError` message type is now deprecated. Both `newError` and the original `error` type now behave identically (using the new implementation that was previously exclusive to `newError`)
 
 ### TextInput
 
 - theme variable `requiredInvalidColor` is now removed
 - `error` or `success` messages are no longer displayed when the component is '`readOnly` or `disabled`
+- `newError` message type is now deprecated. Both `newError` and the original `error` type now behave identically (using the new implementation that was previously exclusive to `newError`)
 
 ### Tabs.Panel
 

packages/ui-popover/src/Popover/index.tsx

@@ -59,10 +59,9 @@ import type { ViewProps, ContextViewProps } from '@instructure/ui-view'
 import type { PositionProps } from '@instructure/ui-position'
 import type { DialogProps } from '@instructure/ui-dialog'
 
-import { withStyleRework as withStyle } from '@instructure/emotion'
+import { withStyle } from '@instructure/emotion'
 
 import generateStyle from './styles'
-import generateComponentTheme from './theme'
 
 import type { PopoverProps, PopoverState } from './props'
 import { allowedProps } from './props'
@@ -75,7 +74,7 @@ tags: overlay, portal, dialog
 **/
 @withDeterministicId()
 @textDirectionContextConsumer()
-@withStyle(generateStyle, generateComponentTheme)
+@withStyle(generateStyle)
 class Popover extends Component<PopoverProps, PopoverState> {
   static readonly componentId = 'Popover'
 

packages/ui-popover/src/Popover/styles.ts

@@ -22,7 +22,7 @@
  * SOFTWARE.
  */
 
-import type { PopoverTheme } from '@instructure/shared-types'
+import type { NewComponentTypes } from '@instructure/ui-themes'
 import type { PopoverStyle } from './props'
 
 /**
@@ -31,11 +31,11 @@ import type { PopoverStyle } from './props'
  * ---
  * Generates the style object from the theme and provided additional information
  * @param  {Object} componentTheme The theme variable object.
- * @param  {Object} props the props of the component, the style is applied to
- * @param  {Object} state the state of the component, the style is applied to
  * @return {Object} The final style object, which will be used in the component
  */
-const generateStyle = (componentTheme: PopoverTheme): PopoverStyle => {
+const generateStyle = (
+  componentTheme: NewComponentTypes['Popover']
+): PopoverStyle => {
   return {
     borderColor: componentTheme.borderColor
   }