-
Notifications
You must be signed in to change notification settings - Fork 106
[v12] feat(ui-alerts): rework Alert #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v12
Are you sure you want to change the base?
Conversation
cca85ff to
7e74077
Compare
|
| fontFamily: componentTheme.contentFontFamily, | ||
| fontWeight: componentTheme.contentFontWeight, | ||
| lineHeight: componentTheme.contentLineHeight, | ||
| padding: componentTheme.contentPadding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put this change into the upgeade guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done it
| borderStyle: componentTheme.borderStyle, | ||
| borderRadius: componentTheme.borderRadius, | ||
| ...variantStyles[variant!].alert, | ||
| ...(hasShadow && { boxShadow: componentTheme.boxShadow }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put this change into the upgrade guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done it.
7e74077 to
7e88113
Compare
INSTUI-4782
7e88113 to
f761f1c
Compare
INSTUI-4782
ISSUE:
TEST PLAN: