fix(ui-list): align ordered list start position with unordered lists #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation divided listPadding by 2, but this did not correctly align ordered and unordered lists. Changed to subtract a fixed 1.3rem offset from the listPadding to ensure both list types start at the same vertical position. To test: Compare ordered and unordered lists side-by-side as shown in the steps to reproduce example. Both list types should now start at the same horizontal position. Fixes #2249 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
git-nandor
approved these changes
Nov 24, 2025
balzss
approved these changes
Nov 24, 2025
| ...(ordered && { | ||
| listStyleType: 'none', | ||
| paddingInlineStart: `calc(${componentTheme.listPadding} / 2)`, | ||
| // 1.3 rem is removed to have the ordered list start at the same point |
Contributor
There was a problem hiding this comment.
this is good for now, but later should be updated to something more "proper"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation divided
listPaddingby 2, but this did not correctly align ordered and unordered lists. Changed to subtract a fixed1.3remoffset from thelistPaddingto ensure both list types start at the same vertical position.To test: Compare ordered and unordered lists side-by-side as shown in the steps to reproduce example. Both list types should now start at the same horizontal position. Test with different override values
Fixes #2249
🤖 Generated with Claude Code