fix(ui-modal): adjust scrollbar detection tolerance in ModalBody #2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase epsilon tolerance from 0.05 to 1 pixel to avoid false positives when detecting scrollbars due to browser rounding errors. This prevents unnecessary tabIndex=0 from being applied when no scrollbar is present. Fixes INSTUI-4863 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
joyenjoyer
approved these changes
Nov 21, 2025
Contributor
|
@matyasf Test plan says "There should be no scrollbar", but there is no scrollbar in the latest version with that code either. Shouldn't we check for the modal body not getting focused instead? I think the fix is about that. |
HerrTopi
approved these changes
Nov 25, 2025
Collaborator
Author
The issue is that there is no test whether the scrollbar is shown, the best thing is what we do -- compare scroll height and bounding box height |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase epsilon tolerance from 0.05 to 1 pixel to avoid false positives when detecting scrollbars due to browser rounding errors. This prevents unnecessary tabIndex=0 from being applied when no scrollbar is present.
Fixes INSTUI-4863
To test:
Set checkbox sizes with this code:
There should be no scrollbar
🤖 Generated with Claude Code