feat(ui-buttons,shared-types): add ai-primary and ai-secondary colors to buttons #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new AI-themed button color variants (ai-primary and ai-secondary) and updates the associated theme variables, styles, and prop types to support these new variants.
- Updated README with examples of AI buttons
- Extended theme definitions and styles for ai-primary and ai-secondary in BaseButton
- Updated prop types and shared theme variables to include the new color options
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-buttons/src/Button/README.md | Added AI button examples to illustrate usage. |
| packages/ui-buttons/src/BaseButton/theme.ts | Added new theme variables for AI button gradients and active state styling. |
| packages/ui-buttons/src/BaseButton/styles.ts | Introduced new style variants for ai-primary and ai-secondary with gradient backgrounds. |
| packages/ui-buttons/src/BaseButton/props.ts | Extended allowed color options to include ai-primary and ai-secondary. |
| packages/shared-types/src/ComponentThemeVariables.ts | Updated type definitions to use string values, and added new AI theme variables. |
| 'ai-secondary': { | ||
| default: { | ||
| background: ` | ||
| linear-gradient(to bottom, ${componentTheme.aiBorderTopGradientColor} 0%, ${componentTheme.aiBorderBottomGradientColor} 100%) text, |
There was a problem hiding this comment.
[nitpick] The use of the 'text' keyword in the ai-secondary default background gradient is not self-explanatory; please add a clarifying comment to explain its intended purpose, especially if it is meant to implement a specific text gradient effect.
|
… to buttons INSTUI-4546
balzss
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST_PLAN: compare with design documentation
INSTUI-4546