Skip to content

Conversation

@balzss
Copy link
Contributor

@balzss balzss commented Apr 16, 2025

INSTUI-4498

test plan

  • go to the dateinput2 docs page and set the first example to every possible timezone offset (e.g. Etc/GMT+4, Etc/GMT+5, Etc/GMT-10, etc.) -> the placeholder should never break

@balzss balzss requested a review from Copilot April 16, 2025 13:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

packages/ui-date-input/src/DateInput2/index.tsx:229

  • The function name 'getDateFromatHint' appears to have a typo. Consider renaming it to 'getDateFormatHint' for clarity.
const getDateFromatHint = () => {

@balzss balzss requested review from ToMESSKa and matyasf April 16, 2025 13:28
@balzss balzss self-assigned this Apr 16, 2025
@github-actions
Copy link

github-actions bot commented Apr 16, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-08 17:48 UTC

Copy link
Contributor

@ToMESSKa ToMESSKa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I provide an invalid timezone like "Invalid/Timezone", it does not give an error anymore. It might be worth noting this in the documentation.

@matyasf matyasf self-requested a review April 29, 2025 15:29
@balzss
Copy link
Contributor Author

balzss commented Apr 30, 2025

If I provide an invalid timezone like "Invalid/Timezone", it does not give an error anymore. It might be worth noting this in the documentation.

@ToMESSKa after some considerations, I think the new behaviour is actually more logical since it falls back to the default. But if it causes confusion in the future, I'll extend the docs

@balzss balzss requested a review from ToMESSKa April 30, 2025 16:20
@balzss balzss force-pushed the fix/dateinput2-placeholder-format branch from 4734f96 to 81dfa4f Compare May 8, 2025 15:06
@balzss balzss merged commit f8229df into master May 8, 2025
8 checks passed
@balzss balzss deleted the fix/dateinput2-placeholder-format branch May 8, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants