Skip to content

Conversation

@balzss
Copy link
Contributor

@balzss balzss commented Mar 17, 2025

INSTUI-4486

test plan:

  • check the code changes
  • check the images generated in chromatic with the button tests
  • check out the branch locally and run the regression app:
    • run install and bootstrap in the root folder
    • go to the regression-test folder
    • run install there too
    • run npm run dev
    • go to localhost:3000 and check out the button example

@balzss balzss self-assigned this Mar 17, 2025
@balzss balzss force-pushed the test/visual-regression-testing branch 2 times, most recently from 1c99466 to 124bc63 Compare March 17, 2025 22:31
@github-actions
Copy link

github-actions bot commented Mar 17, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-07 12:43 UTC

@balzss balzss force-pushed the test/visual-regression-testing branch 4 times, most recently from 594894e to 522ac51 Compare March 18, 2025 19:10
@balzss balzss changed the title wip: comment under pr wip: cypress + chromatic Mar 18, 2025
@balzss balzss force-pushed the test/visual-regression-testing branch 5 times, most recently from 60a76f7 to c6f1de4 Compare March 18, 2025 20:11
@balzss balzss force-pushed the test/visual-regression-testing branch 3 times, most recently from b6e2d15 to 478a870 Compare April 30, 2025 12:04
@balzss balzss changed the title wip: cypress + chromatic introduce new visual regression tests with chromatic instead of storybook Apr 30, 2025
@balzss balzss requested review from joyenjoyer and matyasf April 30, 2025 12:09
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments, nice work!

Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, check the comments

@balzss balzss force-pushed the test/visual-regression-testing branch from 478a870 to a01f487 Compare May 6, 2025 16:03
@balzss balzss force-pushed the test/visual-regression-testing branch from a01f487 to 5d66e66 Compare May 6, 2025 16:55
@balzss balzss requested review from joyenjoyer and matyasf May 6, 2025 17:07
@instructure instructure deleted a comment from github-actions bot May 7, 2025
@instructure instructure deleted a comment from github-actions bot May 7, 2025
@balzss balzss merged commit 8f8793a into master May 7, 2025
8 checks passed
@balzss balzss deleted the test/visual-regression-testing branch May 7, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants