-
Notifications
You must be signed in to change notification settings - Fork 107
introduce new visual regression tests with chromatic instead of storybook #1908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c99466 to
124bc63
Compare
|
594894e to
522ac51
Compare
60a76f7 to
c6f1de4
Compare
b6e2d15 to
478a870
Compare
matyasf
requested changes
May 5, 2025
Collaborator
matyasf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments, nice work!
joyenjoyer
reviewed
May 5, 2025
joyenjoyer
requested changes
May 5, 2025
Contributor
joyenjoyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job, check the comments
478a870 to
a01f487
Compare
a01f487 to
5d66e66
Compare
matyasf
approved these changes
May 7, 2025
joyenjoyer
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4486
test plan:
regression-testfoldernpm run devlocalhost:3000and check out the button example