Release Student 8.4.2 (285) #3455
Conversation
* Fixed duplicate key issue * Distinct by id * Add distinctBy to other places.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR addresses duplicate planner items appearing in the todo list by adding distinctBy { it.id } filtering across multiple locations. The implementation is solid with excellent test coverage.
Positive Aspects
✅ Consistent Implementation - The deduplication logic is applied consistently across all relevant locations (CallbackActivity, ToDoWidgetUpdater, and ToDoListViewModel)
✅ Excellent Test Coverage - Five comprehensive test cases cover various duplicate scenarios:
- Single duplicate items
- Multiple duplicates of the same item
- Duplicates across different date groups
- Verification that first occurrence is preserved
- Multiple different duplicates
✅ Clean Solution - Using distinctBy { it.id } is idiomatic Kotlin and performs well
✅ Version Bump - Properly incremented version from 8.4.1 to 8.4.2
✅ API Updates - Updated service URLs to new infrastructure (core.inseng.io)
Items to Consider
- Filter Order - Verify that applying
distinctByafter filtering announcements/assessment requests is intentional. If duplicates can exist with different plannable types (e.g., ID=1 as ANNOUNCEMENT and ID=1 as ASSIGNMENT), the current order keeps non-filtered types. See inline comments onToDoListViewModel.kt:152andCallbackActivity.kt:269
Code Quality Assessment
- No bugs detected - Logic is sound
- No security concerns - Changes are data filtering only
- Performance -
distinctByis O(n) and appropriate for this use case - No missing edge cases - Test coverage is thorough
The duplicate filtering strategy (keeping first occurrence) is reasonable and well-tested. Great work on the comprehensive test suite!
No description provided.