Skip to content

[tests] Add explicit create true for extraFields test#2401

Merged
nezaj merged 1 commit intomainfrom
sm-e2e-test
Mar 23, 2026
Merged

[tests] Add explicit create true for extraFields test#2401
nezaj merged 1 commit intomainfrom
sm-e2e-test

Conversation

@nezaj
Copy link
Contributor

@nezaj nezaj commented Mar 23, 2026

What it says on the tin!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a2d823f8-9142-49cc-9bbb-b2caea7f159f

📥 Commits

Reviewing files that changed from the base of the PR and between a916e96 and ff39e94.

📒 Files selected for processing (1)
  • client/packages/core/__tests__/src/auth-extra-fields.e2e.test.ts

📝 Walkthrough

Walkthrough

Updated e2e test harness configuration by adding explicit authorization rules for code operations on users. The change replaces a basic schema parameter with an extended configuration that includes access control policies, affecting the test environment's security rules without modifying test logic or assertions.

Changes

Cohort / File(s) Summary
Auth Extra Fields E2E Test Configuration
client/packages/core/__tests__/src/auth-extra-fields.e2e.test.ts
Added explicit authorization rules to test harness configuration, specifying code resource access permissions for $users entity with create operation allowed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • stopachka
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding explicit authorization rules for create operations in an extraFields test configuration.
Description check ✅ Passed The description is extremely minimal but directly relates to the changeset by confirming the title's intent without providing additional context.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sm-e2e-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

View Vercel preview at instant-www-js-sm-e2e-test-jsv.vercel.app.

Copy link
Contributor

@dwwoelfel dwwoelfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nezaj nezaj merged commit 3300a9e into main Mar 23, 2026
28 checks passed
@nezaj nezaj deleted the sm-e2e-test branch March 23, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants