Skip to content

Conversation

@JemmaLDaniel
Copy link
Collaborator

Fix: Add spectrum_id column to both output files

This ensures the spectrum_id column is included in both output files generated by the winnow predict command.

Changes:

  • Removed spectrum_id from the columns dropped from the metadata dataframe, so it remains in metadata.csv
  • Explicitly added spectrum_id to the predictions and FDR metrics dataframe, so it's included in preds_and_fdr_metrics.csv

Impact:

Both metadata.csv and preds_and_fdr_metrics.csv now contain the spectrum_id column, enabling proper joining and identification of spectra across outputs.

@JemmaLDaniel JemmaLDaniel requested a review from BioGeek November 11, 2025 12:48
@JemmaLDaniel JemmaLDaniel self-assigned this Nov 11, 2025
@JemmaLDaniel JemmaLDaniel added the bug Something isn't working label Nov 11, 2025
Copy link
Contributor

@BioGeek BioGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JemmaLDaniel JemmaLDaniel linked an issue Nov 14, 2025 that may be closed by this pull request
@JemmaLDaniel JemmaLDaniel merged commit 4b36642 into main Nov 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Separate saved outputs into features and FDR metrics

3 participants