Skip to content

Upgrade react + related deps; upgrade react-styleguidist #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wfro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade react + related deps; upgrade react-styleguidist #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2
jobs:
build:
docker:
- image: circleci/node:8.11.4
- image: circleci/node:10

working_directory: ~/repo

Expand Down
13 changes: 8 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
"version": "0.0.143",
"description": "The Instacart Component Library for Web",
"main": "dist/snacks.js",
"engines": {
"node": ">=10.0.0 <11.0.0"
},
"module": "dist/esm/index.js",
"types": "dist/esm/index.d.ts",
"scripts": {
Expand Down Expand Up @@ -64,7 +67,7 @@
"coveralls": "^3.0.5",
"enzyme": "^3.10.0",
"enzyme-adapter-react-16": "^1.15.1",
"enzyme-to-json": "^3.3.3",
"enzyme-to-json": "^3.4.3",
"eslint": "6.2.2",
"eslint-import-resolver-webpack": "0.11.0",
"fs-extra": "^5.0.0",
Expand All @@ -73,10 +76,10 @@
"prettier": "1.16.4",
"prompt": "^1.0.0",
"radium": "^0.22.0",
"react": "16.4.2",
"react-dom": "16.4.2",
"react-styleguidist": "9.0.9",
"react-test-renderer": "16.4.2",
"react": "^16.12.0",
Copy link
Copy Markdown
Member

@NinjaBanjo NinjaBanjo Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should prob make sure this is a minor version change, as react updating is not insignificant (bundle sizes and all)

Copy link
Copy Markdown
Contributor Author

@wfro wfro Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍 , I think this would actually somehow be the first non-patch release.

"react-dom": "^16.12.0",
"react-styleguidist": "^10.2.1",
"react-test-renderer": "^16.12.0",
"react-transition-group": "^2.2.1",
"sinon": "^7.3.2",
"terser-webpack-plugin": "^2.3.2",
Expand Down
Loading