Merged
Conversation
Contributor
|
✅ All contributors have signed the CLA |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
3 tasks
Contributor
Unit Tests Summary 1 files 178 suites 46s ⏱️ Results for commit ebd71ca. |
Contributor
Unit Tests Summary 1 files 178 suites 54s ⏱️ Results for commit ebd71ca. |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit 05afb67 ♻️ This comment has been updated with latest results. |
Contributor
Code Coverage SummaryDiff against mainResults for commit: ebd71ca Minimum allowed coverage is ♻️ This comment has been updated with latest results |
m7pr
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Use svg logo instead of the png to reduce package size
This is in reference to insightsengineering/nestdevs-tasks#93
The logo was generated with the script at: insightsengineering/hex-stickers#39
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()devtools::test_coverage()Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()When the branch is ready to be merged:
NEWS.mdwith the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).