refactor: Guarantee import operations are stateless by making them static functions #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atic functions Since we’ve been seeing some failures when running imports in parallel, it makes sense to refactor the code a little to guarantee that import operations are stateless. Thankfully, this didn’t require any change to the importers themselves, so we can now have a little more confidence in their implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we’ve been seeing some failures when running imports in parallel, it makes sense to refactor the code a little to guarantee that import operations are stateless. Thankfully, this didn’t require any change to the importers themselves, so we can now have a little more confidence in their implementation.