Implementation of Code Challenge #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 9, 2021 20:29
- Added UI, Network, Pod file
bghoward
commented
Mar 22, 2021
|
|
||
| class func httpParametersString(parameters: [String: AnyHashable]) -> String { | ||
| var parametersString = "" | ||
| let parameterKeys = Array(parameters.keys) |
Author
There was a problem hiding this comment.
No need to create a temporary array here. I think this can be simplified.
var parametersString = ""
parameters.forEach { (key, val) in
let encodedParameterKey = urlEncode(string: key)
let encodedParameterValue = urlEncode(string: "\(val)")
parametersString += "&=\(encodedParameterKey)=\(encodedParameterValue)"
}
return parametersString.dropFirst().description
| guard let parameters = parameters else { | ||
| return request | ||
| } | ||
| if request.httpMethod == RequestConfiguration.HTTPMethod.get.rawValue { |
Author
There was a problem hiding this comment.
Why not use a switch here?
guard let m = request.httpMethod, let method = RequestConfiguration.HTTPMethod.init(rawValue: m) else {
return request
}
switch method {
case .get:
var parametersString = httpParametersString(parameters: parameters)
if !parametersString.isEmpty {
parametersString = "?" + parametersString
}
if let url = request.url {
let urlStringWithParameters = url.absoluteString + parametersString
if let urlWithParameters = URL(string: urlStringWithParameters) {
request.url = urlWithParameters
}
}
case .post, .put:
let parametersString = httpParametersString(parameters: parameters)
request.httpBody = parametersString.data(using: .utf8)
default:
break
}
return request
| modelRequestCompletion?(.success(dataResponse)) | ||
| return | ||
| } catch { | ||
| modelRequestCompletion?(.failure(NetworkError.decodeModelFailure(error: error))) |
Author
There was a problem hiding this comment.
Missing a return here. If an error occurs then the modelRequestCompletion will get called twice, with the last one being a success.
| func fetchPhotos() { | ||
| self.setState(state: .loading) | ||
| photoRepository!.fetchPhotos(completion: { (result) in | ||
| DispatchQueue.main.async { |
Author
There was a problem hiding this comment.
This might be better to put the main dispatch in the PhotoRepository
| func fetchPhotos(completion: PhotoDataSourceCompletion?) { | ||
| let requestConfiguration = RequestConfiguration(endpoint: "https://jsonplaceholder.typicode.com/photos", httpMethod: .get, parameters: nil) | ||
| networkManager.executeRequest(requestConfiguration: requestConfiguration, responseModel: [Photo].self) { result in | ||
| switch result { |
Author
There was a problem hiding this comment.
move back to the main thread before calling the completion handler
| private var selectedPhoto: Photo? | ||
|
|
||
| private let networkManager = NetworkManager() | ||
| private var photoRepository : PhotoRepository? |
Author
There was a problem hiding this comment.
You should be able to make this non-optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.