refactor: decouple EmbPattern from readers/writers#123
Merged
not-my-profile merged 1 commit intoinkstitch:mainfrom Aug 2, 2025
Merged
refactor: decouple EmbPattern from readers/writers#123not-my-profile merged 1 commit intoinkstitch:mainfrom
not-my-profile merged 1 commit intoinkstitch:mainfrom
Conversation
In the reader and writer implementations we want to add EmbPattern as type hints, however when imported relatively this lead to a circular import since EmbPattern.py imported all the readers and writers. This commit resolves this circular dependency by moving the read and write methods that select the writer depending on the file extension to __init__.py (as well as supported_formats and the format-specific read and write methods).
kaalleen
approved these changes
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the reader and writer implementations we want to add EmbPattern as type hints, however when imported relatively this lead to a circular import since EmbPattern.py imported all the readers and writers.
This commit resolves this circular dependency by moving the read and write methods that select the writer depending on the file extension to init.py (as well as supported_formats and the format-specific read and write methods).