This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Handle connecting via tcp socket #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi! Thanks for this. I'll take a better look when I have time at home, but so far looks fantastic! |
Owner
|
@joerocklin sorry I hadn't had the time to try this yet, it's been some terrible weeks. |
Author
|
@inkel no worries, I had some other things I was going to look at and got pulled in other directions as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests pass, though no new ones have been written to test the tcp socket handling, mostly because I'm not sure how to handle mocking the TCP socket.