[DSD-9870] inji-verify 0.17.0 release#235
Conversation
Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>
WalkthroughThis PR updates published version strings from SNAPSHOT to release versions across build/publish metadata: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@vc-verifier/kotlin/vcverifier/publish-artifact.gradle`:
- Line 99: The publication blocks that hardcode version = "1.7.0" must be
unified with the jarRelease task metadata to avoid version drift: introduce a
single releaseVersion value (e.g., val releaseVersion =
(findProperty("VCVERIFIER_VERSION") ?: project.version).toString()) and use that
variable everywhere — replace the hardcoded publication version values in the
publish-artifact.gradle publication blocks with releaseVersion and update the
jarRelease task (manifest attribute "Implementation-Version" and
archiveVersion.set(...)) to also use releaseVersion so the published artifact
and its embedded metadata match.
ℹ️ Review info
Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3f5f5e17-e271-4cac-8f46-189aa4efce18
📒 Files selected for processing (1)
vc-verifier/kotlin/vcverifier/publish-artifact.gradle
Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@vc-verifier/kotlin/sample-java-app/pom.xml`:
- Line 54: The sample app's pom dependency for artifactId "vcverifier-jar" is
pinned to version 1.5.0; update the <version> element in the sample project's
pom.xml to 1.7.0 so the sample uses the same release as declared in
vc-verifier/kotlin/vcverifier/build.gradle.kts, ensuring the sample exercises
the published artifact.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8b2f03bc-949d-473e-a36a-989c995633f3
📒 Files selected for processing (2)
vc-verifier/kotlin/sample-java-app/pom.xmlvc-verifier/kotlin/vcverifier/build.gradle.kts
Summary by CodeRabbit