Skip to content

[DRAFT PR] Critical Code Review for Inji Web release 0.15.0#959

Merged
Prafulrakhade merged 0 commit intomasterfrom
release-0.20.x
Dec 1, 2025
Merged

[DRAFT PR] Critical Code Review for Inji Web release 0.15.0#959
Prafulrakhade merged 0 commit intomasterfrom
release-0.20.x

Conversation

@swatigoel
Copy link
Contributor

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Nov 4, 2025

Note

Reviews paused

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release-0.20.x

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@swatigoel swatigoel marked this pull request as draft November 4, 2025 12:25

minio:
container_name: 'minio-service'
image: mosipint/minio:2022.2.7-debian-10-r0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prafulrakhade do we have mosipid image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prafulrakhade do we have mosipid image?

@swatigoel
Copy link
Contributor Author

@jackjain there are 3 services PresentationService PresentationActionService and PresentationSubmissionService
Let's try to simplify these with their responsibilities.

* and Nimbus JOSE library for consistency across the application.
*/
@UtilityClass
public class Base64Util {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason to have this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used to perform encoding and decoding of the Unsigned Token before signing

}'
output: '{
"name": "MosipVerifiableCredential"
"name": "MOSIPVerifiableCredential"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hegdenitin have we handled case insensitivity in this release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be handled as part of next release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hegdenitin why, it was discussed around couple of months back?

@kongadurgesh
Copy link
Contributor

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Nov 18, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jackjain
Copy link
Contributor

@coderabbitai ignore

@coderabbitai
Copy link

coderabbitai bot commented Nov 18, 2025

✅ Actions performed

Reviews paused.

@Prafulrakhade Prafulrakhade merged commit f426da3 into master Dec 1, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants