[DRAFT PR] Critical Code Review for Inji Web release 0.15.0#959
[DRAFT PR] Critical Code Review for Inji Web release 0.15.0#959Prafulrakhade merged 0 commit intomasterfrom
Conversation
|
Note Reviews pausedUse the following commands to manage reviews:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
...n/java/io/mosip/testrig/apirig/mimoto/testscripts/GetWithPathParamAndCookieForAutoGenId.java
Show resolved
Hide resolved
api-test/src/main/java/io/mosip/testrig/apirig/mimoto/utils/MimotoUtil.java
Show resolved
Hide resolved
db_upgrade_script/inji_mimoto/sql/0.19.1_to_0.20.0_rollback.sql
Outdated
Show resolved
Hide resolved
|
|
||
| minio: | ||
| container_name: 'minio-service' | ||
| image: mosipint/minio:2022.2.7-debian-10-r0 |
There was a problem hiding this comment.
@Prafulrakhade do we have mosipid image?
helm/mimoto/values.yaml
Outdated
There was a problem hiding this comment.
@Prafulrakhade do we have mosipid image?
src/main/java/io/mosip/mimoto/dto/VerifiablePresentationAuthorizationRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/mosip/mimoto/service/impl/CredentialMatchingServiceImpl.java
Show resolved
Hide resolved
src/main/java/io/mosip/mimoto/service/impl/CredentialMatchingServiceImpl.java
Show resolved
Hide resolved
src/main/java/io/mosip/mimoto/controller/WalletPresentationsController.java
Outdated
Show resolved
Hide resolved
src/main/java/io/mosip/mimoto/service/impl/CredentialMatchingServiceImpl.java
Show resolved
Hide resolved
|
@jackjain there are 3 services |
| * and Nimbus JOSE library for consistency across the application. | ||
| */ | ||
| @UtilityClass | ||
| public class Base64Util { |
There was a problem hiding this comment.
what's the reason to have this?
There was a problem hiding this comment.
Used to perform encoding and decoding of the Unsigned Token before signing
...sentations/VerifiablePresentationAuthorization/VerifiablePresentationAuthorizationResult.hbs
Show resolved
Hide resolved
| }' | ||
| output: '{ | ||
| "name": "MosipVerifiableCredential" | ||
| "name": "MOSIPVerifiableCredential" |
There was a problem hiding this comment.
@hegdenitin have we handled case insensitivity in this release?
There was a problem hiding this comment.
will be handled as part of next release
There was a problem hiding this comment.
@hegdenitin why, it was discussed around couple of months back?
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai ignore |
✅ Actions performedReviews paused. |
No description provided.