Skip to content

[MOSIP-44526] Updated values.yaml#1042

Merged
Prafulrakhade merged 1 commit intoinji:developfrom
abhishek8shankar:MOSIP-44542
Mar 4, 2026
Merged

[MOSIP-44526] Updated values.yaml#1042
Prafulrakhade merged 1 commit intoinji:developfrom
abhishek8shankar:MOSIP-44542

Conversation

@abhishek8shankar
Copy link
Contributor

@abhishek8shankar abhishek8shankar commented Mar 4, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated deployment configuration for database connection environment variables
    • Modified container security context settings in deployment configuration

Signed-off-by: Abhi <abhishek.shankarcs@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 4, 2026

Walkthrough

Two Helm configuration files updated: containerSecurityContext.runAsUser changed from numeric 1001 to string "inji" in mimoto-apitestrig, and database environment variable keys renamed from INJI_ prefix to MOSIP_ prefix in mimoto values.

Changes

Cohort / File(s) Summary
Container Security Context
deploy/mimoto-apitestrig/values.yaml
Updated containerSecurityContext.runAsUser from numeric value 1001 to string "inji".
Environment Variables
deploy/mimoto/values.yaml
Renamed database environment variable keys: INJI_MIMOTO_DATABASE_HOSTNAME → MOSIP_MIMOTO_DATABASE_HOSTNAME and INJI_MIMOTO_DATABASE_PORT → MOSIP_MIMOTO_DATABASE_PORT.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • ckm007

Poem

🐰 A user becomes a name, "inji" now takes the stage,
Database keys dance from INJI to MOSIP's page,
Config files shimmer in their helm-chart disguise,
Simple, yet crucial—identity before our eyes! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and generic, using only 'Updated values.yaml' without specifying what was actually changed or why. Provide a more descriptive title that captures the main changes, such as 'Update environment variable names and container security context' or reference the specific purpose of the updates.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@deploy/mimoto-apitestrig/values.yaml`:
- Line 6: Change the runAsUser value from the string "inji" to the numeric UID
used in the base chart (use 1001) so Kubernetes receives an int64, e.g. set
runAsUser: 1001 (no quotes); ensure this value is used when
containerSecurityContext.enabled is true and matches the base
helm/mimoto/values.yaml UID to prevent deployment failures.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0053c05b-3bc9-46d1-8a10-c8d9bf23a00f

📥 Commits

Reviewing files that changed from the base of the PR and between e753b52 and d7eeacc.

📒 Files selected for processing (2)
  • deploy/mimoto-apitestrig/values.yaml
  • deploy/mimoto/values.yaml

@Prafulrakhade Prafulrakhade merged commit 02b6938 into inji:develop Mar 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants