fix: [INJIWEB-1145] changed Selected Document to Selected Credential#482
fix: [INJIWEB-1145] changed Selected Document to Selected Credential#482sanehema9 wants to merge 1 commit intoinji:developfrom
Conversation
Signed-off-by: sanehema9 <sanehema9@gmail.com>
WalkthroughLocalization updates across seven language files that rename the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
inji-web/src/locales/hi.json (1)
376-376: LGTM! Hindi translation updated correctly.The Hindi translation has been updated from "चयनित दस्तावेज़" to "चयनित क्रेडेंशियल", correctly reflecting the terminology change from document to credential.
Optional: Consider updating the JSON key name for consistency.
While not critical, the JSON key
selectedDocumentcould be renamed toselectedCredentialin a future refactor to align with the new terminology. This would improve code readability and consistency.inji-web/src/locales/en.json (1)
376-376: LGTM! Terminology update improves consistency.The change from "Selected Document" to "Selected Credential" aligns with the PR objective and ensures consistent terminology across the application.
💡 Optional: Consider key naming consistency in future refactoring
The key name
selectedDocumentnow displays "Selected Credential". While this works perfectly and avoids breaking existing code references, you might consider renaming the key toselectedCredentialin a future refactoring effort for complete consistency. However, this would require updating all code references and is not necessary for this PR.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
inji-web/src/locales/ar.jsoninji-web/src/locales/en.jsoninji-web/src/locales/fr.jsoninji-web/src/locales/hi.jsoninji-web/src/locales/kn.jsoninji-web/src/locales/pt.jsoninji-web/src/locales/ta.json
🔇 Additional comments (5)
inji-web/src/locales/fr.json (1)
376-376: LGTM! Translation update looks correct.The French translation has been appropriately updated from "Document sélectionné" to "Identifiant sélectionné", which correctly reflects the terminology change from "document" to "credential".
inji-web/src/locales/ta.json (1)
376-376: LGTM! Tamil translation updated correctly.The Tamil translation has been updated to reflect the credential terminology change, maintaining consistency with the overall PR objective.
inji-web/src/locales/kn.json (1)
376-376: LGTM! Kannada translation updated correctly.The Kannada translation has been updated from "ಆಯ್ದ ಡಾಕ್ಯುಮೆಂಟ್" to "ಆಯ್ಕೆಮಾಡಿದ ರುಜುವಾತು", correctly reflecting the credential terminology change.
inji-web/src/locales/pt.json (1)
376-376: LGTM! Portuguese translation updated correctly.The Portuguese translation has been appropriately updated from "Documento selecionado" to "Credencial selecionada", maintaining proper gender agreement and reflecting the terminology change.
inji-web/src/locales/ar.json (1)
376-376: Translation verified as accurate and appropriate.The Arabic translation "بيانات الاعتماد المختارة" correctly represents "Selected Credential" in the digital identity context. This matches the recommended phrasing for UI credential selectors and aligns with the English terminology change from literal "document" to "credential."
| "subTitle": "Veuillez donner votre consentement pour définir une validité pour le partage du {{credentialName}}", | ||
| "content": { | ||
| "selectedDocument": "Document sélectionné", | ||
| "selectedDocument": "Identifiant sélectionné", |
There was a problem hiding this comment.
@sanchi-singh24 can you please confirm on this translation text ?
Description
Changed "Selected Document" to "Selected Credential" in language translation files for consistent terminology across the application.
Changes:
Issue ticket number and link
INJIWEB-1145
Screenshot
Video
INJIWEB-1145.mp4
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.