Skip to content

fix: [INJIWEB-1145] changed Selected Document to Selected Credential#482

Open
sanehema9 wants to merge 1 commit intoinji:developfrom
sanehema9:fix/INJIWEB-1145-select-document
Open

fix: [INJIWEB-1145] changed Selected Document to Selected Credential#482
sanehema9 wants to merge 1 commit intoinji:developfrom
sanehema9:fix/INJIWEB-1145-select-document

Conversation

@sanehema9
Copy link

@sanehema9 sanehema9 commented Jan 8, 2026

Description

Changed "Selected Document" to "Selected Credential" in language translation files for consistent terminology across the application.

Changes:

  • Updated translation keys in JSON language files
  • Changed all instances of "Selected Document" to "Selected Credential"

Issue ticket number and link

INJIWEB-1145

Screenshot

image

Video

INJIWEB-1145.mp4

Summary by CodeRabbit

  • Documentation
    • Updated localization strings across seven languages (English, Arabic, French, Hindi, Kannada, Portuguese, and Tamil). Changed the displayed label from "Selected Document" to "Selected Credential" in the data sharing expiry modal for improved terminology clarity.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: sanehema9 <sanehema9@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 8, 2026

Walkthrough

Localization updates across seven language files that rename the DataShareExpiryModal.content.selectedDocument key label from "Document" to "Credential" in Arabic, English, French, Hindi, Kannada, Portuguese, and Tamil translations.

Changes

Cohort / File(s) Summary
Locale File Updates
inji-web/src/locales/ar.json, inji-web/src/locales/en.json, inji-web/src/locales/fr.json, inji-web/src/locales/hi.json, inji-web/src/locales/kn.json, inji-web/src/locales/pt.json, inji-web/src/locales/ta.json
Updated DataShareExpiryModal.content.selectedDocument label from "Selected Document" (or language equivalent) to "Selected Credential" across all supported language translations

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 From Document to Credential, a shift so neat,
Seven tongues sing translations complete,
In Arabic, Hindi, French—voices unite,
Modal labels gleam with accuracy bright,
A credential's true name, finally right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: updating terminology from 'Selected Document' to 'Selected Credential' across all translation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
inji-web/src/locales/hi.json (1)

376-376: LGTM! Hindi translation updated correctly.

The Hindi translation has been updated from "चयनित दस्तावेज़" to "चयनित क्रेडेंशियल", correctly reflecting the terminology change from document to credential.

Optional: Consider updating the JSON key name for consistency.

While not critical, the JSON key selectedDocument could be renamed to selectedCredential in a future refactor to align with the new terminology. This would improve code readability and consistency.

inji-web/src/locales/en.json (1)

376-376: LGTM! Terminology update improves consistency.

The change from "Selected Document" to "Selected Credential" aligns with the PR objective and ensures consistent terminology across the application.

💡 Optional: Consider key naming consistency in future refactoring

The key name selectedDocument now displays "Selected Credential". While this works perfectly and avoids breaking existing code references, you might consider renaming the key to selectedCredential in a future refactoring effort for complete consistency. However, this would require updating all code references and is not necessary for this PR.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4c7129 and cb62367.

📒 Files selected for processing (7)
  • inji-web/src/locales/ar.json
  • inji-web/src/locales/en.json
  • inji-web/src/locales/fr.json
  • inji-web/src/locales/hi.json
  • inji-web/src/locales/kn.json
  • inji-web/src/locales/pt.json
  • inji-web/src/locales/ta.json
🔇 Additional comments (5)
inji-web/src/locales/fr.json (1)

376-376: LGTM! Translation update looks correct.

The French translation has been appropriately updated from "Document sélectionné" to "Identifiant sélectionné", which correctly reflects the terminology change from "document" to "credential".

inji-web/src/locales/ta.json (1)

376-376: LGTM! Tamil translation updated correctly.

The Tamil translation has been updated to reflect the credential terminology change, maintaining consistency with the overall PR objective.

inji-web/src/locales/kn.json (1)

376-376: LGTM! Kannada translation updated correctly.

The Kannada translation has been updated from "ಆಯ್ದ ಡಾಕ್‌ಯುಮೆಂಟ್" to "ಆಯ್ಕೆಮಾಡಿದ ರುಜುವಾತು", correctly reflecting the credential terminology change.

inji-web/src/locales/pt.json (1)

376-376: LGTM! Portuguese translation updated correctly.

The Portuguese translation has been appropriately updated from "Documento selecionado" to "Credencial selecionada", maintaining proper gender agreement and reflecting the terminology change.

inji-web/src/locales/ar.json (1)

376-376: Translation verified as accurate and appropriate.

The Arabic translation "بيانات الاعتماد المختارة" correctly represents "Selected Credential" in the digital identity context. This matches the recommended phrasing for UI credential selectors and aligns with the English terminology change from literal "document" to "credential."

@sanehema9 sanehema9 closed this Jan 15, 2026
@sanehema9 sanehema9 reopened this Jan 15, 2026
"subTitle": "Veuillez donner votre consentement pour définir une validité pour le partage du {{credentialName}}",
"content": {
"selectedDocument": "Document sélectionné",
"selectedDocument": "Identifiant sélectionné",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanchi-singh24 can you please confirm on this translation text ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants