INJIWEB-1141-Fixed copyright information not center aligned for Tamil in tablet view#477
INJIWEB-1141-Fixed copyright information not center aligned for Tamil in tablet view#477iamlokanath wants to merge 3 commits intoinji:developfrom
Conversation
Signed-off-by: Lkanath Panda <lokanthpanda128@gmai.com>
WalkthroughFormatting around the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In @inji-web/src/components/PageTemplate/Footer.tsx:
- Line 20: The unconditional "text-right" in the className on Footer.tsx should
be made conditional using the existing isRTL(language) pattern from Sidebar.tsx;
replace the literal 'text-right' in the className template with either
`${isRTL(language) ? 'text-right' : ''}` (if you want RTL at all viewports) or
`${isRTL(language) ? 'md:text-right' : ''}` (if you only want RTL on tablet+ as
the PR describes), ensuring the `language` variable is in scope and preserving
the rest of the class string.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
inji-web/src/__tests__/components/PageTemplate/__snapshots__/Footer.test.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (1)
inji-web/src/components/PageTemplate/Footer.tsx
| <p | ||
| data-testid="Footer-Text" | ||
| className="ps-7 text-[#9E9E9E] transform rotate-180 text-[16px] leading-[24px] font-medium mr-4" | ||
| className="ps-7 text-[#9E9E9E] transform rotate-180 text-[16px] leading-[24px] font-medium mr-4 text-right" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for language switching logic and Footer implementation
echo "=== Checking Footer.tsx implementation ==="
cat inji-web/src/components/PageTemplate/Footer.tsx
echo ""
echo "=== Searching for translation/language files ==="
find inji-web -type f \( -name "*lang*" -o -name "*i18n*" -o -name "*translation*" \) | head -20
echo ""
echo "=== Checking for language-specific conditional rendering patterns ==="
rg "useLanguage|language === |i18n\.|lang " inji-web/src/components/PageTemplate/ --type tsx --type tsRepository: inji/inji-web
Length of output: 1876
🏁 Script executed:
#!/bin/bash
# Continue investigation
echo "=== Checking i18n configuration ==="
cat inji-web/src/utils/i18n.ts
echo ""
echo "=== Searching for text-right usage across codebase ==="
rg "text-right" inji-web/src --type-add 'tsx:*.tsx' --type-add 'ts:*.ts' -C 1 | head -30
echo ""
echo "=== Searching for responsive text alignment (md:text-*, sm:text-*) ==="
rg "(sm|md|lg|xl):(text-left|text-right|text-center)" inji-web/src --type-add 'tsx:*.tsx' --type-add 'ts:*.ts'
echo ""
echo "=== Checking if there are other instances of rotate-180 ==="
rg "rotate-180" inji-web/src --type-add 'tsx:*.tsx' --type-add 'ts:*.ts' | head -20Repository: inji/inji-web
Length of output: 6322
Align the text-right class conditionally based on language and viewport, matching the established pattern in the codebase.
The text-right class is applied unconditionally, but:
- The codebase establishes a language-conditional pattern in Sidebar.tsx:
${isRTL(language) ? 'text-right' : ''} - The PR specifies "Tamil in tablet view," but the fix applies to all 7 supported languages (including Arabic, which is RTL) and all viewports
- Responsive modifiers (e.g.,
md:text-right) are used elsewhere for viewport-specific changes
Apply text-right only for RTL languages or add responsive modifiers if it should only apply on tablet and larger screens. Use the same isRTL() pattern established in Sidebar for consistency.
🤖 Prompt for AI Agents
In @inji-web/src/components/PageTemplate/Footer.tsx at line 20, The
unconditional "text-right" in the className on Footer.tsx should be made
conditional using the existing isRTL(language) pattern from Sidebar.tsx; replace
the literal 'text-right' in the className template with either
`${isRTL(language) ? 'text-right' : ''}` (if you want RTL at all viewports) or
`${isRTL(language) ? 'md:text-right' : ''}` (if you only want RTL on tablet+ as
the PR describes), ensuring the `language` variable is in scope and preserving
the rest of the class string.
INJIWEB-1141.mp4 |
|
…gned like English (including Tamil when it wraps). Removied the isRTL conditional and reverted to always using text-right. Signed-off-by: Lkanath Panda <lokanthpanda128@gmai.com>
…o injiweb-1141
INJIWEB1141.mp4 |



Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.