Update sonar analysis workflow and Slack webhook#141
Conversation
Signed-off-by: Rajapandi M <138785181+rajapandi1234@users.noreply.github.com>
WalkthroughGitHub Actions workflow configuration updated to use a different upstream workflow variant ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/push-trigger.yml (1)
52-65:⚠️ Potential issue | 🟡 MinorIncomplete migration — two sonar jobs still reference the old workflow and secret.
sonar_analysis_mosip-identity-certify-plugin(Line 96) andsonar_analysis_mock-certify-plugin(Line 137) still usemaven-sonar-analysis-new.yml@developandSLACK_WEBHOOK, while the two updated jobs now diverge tomaven-sonar-analysis.yml@dsd9685andSLACK_WEBHOOK_INJI_TEAM. Unless the intent is deliberately asymmetric, these two jobs should receive the same update.🔧 Proposed fix for the two skipped jobs
sonar_analysis_mosip-identity-certify-plugin: needs: build-maven-mosip-identity-certify-plugin if: "${{ github.event_name != 'pull_request' }}" - uses: mosip/kattu/.github/workflows/maven-sonar-analysis-new.yml@develop + uses: mosip/kattu/.github/workflows/maven-sonar-analysis.yml@dsd9685 with: SERVICE_LOCATION: mosip-identity-certify-plugin secrets: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} ORG_KEY: ${{ secrets.ORG_KEY }} OSSRH_USER: ${{ secrets.OSSRH_USER }} OSSRH_SECRET: ${{ secrets.OSSRH_SECRET }} OSSRH_TOKEN: ${{ secrets.OSSRH_TOKEN }} GPG_SECRET: ${{ secrets.GPG_SECRET }} - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }} + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_INJI_TEAM }} sonar_analysis_mock-certify-plugin: needs: build-maven-mock-certify-plugin if: "${{ github.event_name != 'pull_request' }}" - uses: mosip/kattu/.github/workflows/maven-sonar-analysis-new.yml@develop + uses: mosip/kattu/.github/workflows/maven-sonar-analysis.yml@dsd9685 with: SERVICE_LOCATION: mock-certify-plugin secrets: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} ORG_KEY: ${{ secrets.ORG_KEY }} OSSRH_USER: ${{ secrets.OSSRH_USER }} OSSRH_SECRET: ${{ secrets.OSSRH_SECRET }} OSSRH_TOKEN: ${{ secrets.OSSRH_TOKEN }} GPG_SECRET: ${{ secrets.GPG_SECRET }} - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }} + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_INJI_TEAM }}Also applies to: 175-188
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/push-trigger.yml around lines 52 - 65, Two sonar jobs (sonar_analysis_mosip-identity-certify-plugin and sonar_analysis_mock-certify-plugin) still reference the old workflow and secret; update their uses from maven-sonar-analysis-new.yml@develop to mosip/kattu/.github/workflows/maven-sonar-analysis.yml@dsd9685 and replace SLACK_WEBHOOK with SLACK_WEBHOOK_INJI_TEAM in their secrets blocks (also apply the same replacement for the other occurrence around the later block referenced), ensuring all sonar_analysis jobs consistently use the same workflow and Slack secret.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/push-trigger.yml:
- Around line 52-65: Two sonar jobs
(sonar_analysis_mosip-identity-certify-plugin and
sonar_analysis_mock-certify-plugin) still reference the old workflow and secret;
update their uses from maven-sonar-analysis-new.yml@develop to
mosip/kattu/.github/workflows/maven-sonar-analysis.yml@dsd9685 and replace
SLACK_WEBHOOK with SLACK_WEBHOOK_INJI_TEAM in their secrets blocks (also apply
the same replacement for the other occurrence around the later block
referenced), ensuring all sonar_analysis jobs consistently use the same workflow
and Slack secret.
Summary by CodeRabbit