[INJICERT-1277] Remove cache dependency from mdoc vc issuance (#139)#140
Merged
swatigoel merged 1 commit intoinji:release-0.6.xfrom Jan 29, 2026
Merged
[INJICERT-1277] Remove cache dependency from mdoc vc issuance (#139)#140swatigoel merged 1 commit intoinji:release-0.6.xfrom
swatigoel merged 1 commit intoinji:release-0.6.xfrom
Conversation
* [INJICERT-1277] Remove cache dependency from mdoc vc issuance Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com> * [INJICERT-1277] Remove unused injected dependencies Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com> * [INJICERT-1277] Fix nitpick comments Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com> --------- Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
WalkthroughThis PR removes key management and caching infrastructure from the MDocMockVCIssuancePlugin, simplifying credential issuance by deriving documentNumber directly from the identity claim's "sub" field instead of accessing external key stores and user info transactions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
swatigoel
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[INJICERT-1277] Remove cache dependency from mdoc vc issuance
[INJICERT-1277] Remove unused injected dependencies
[INJICERT-1277] Fix nitpick comments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.