Skip to content

[INJICERT-1145] Rebase develop with release-0.5.x changes #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swatigoel merged 2 commits into from
Jan 21, 2026
Merged

[INJICERT-1145] Rebase develop with release-0.5.x changes #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38941d8
[INJICERT-1145] Fix mdoc failure issue (#118)
Piyush7034 Jul 18, 2025
0284308
[INJICERT-1145] Remove VerifiableCredentia as first type condition
Piyush7034 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mock-certify-plugin/src/main/java/io/mosip/certify/mock/integration/mocks/MdocGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import com.android.identity.mdoc.util.MdocUtil;
import com.android.identity.util.Timestamp;
import io.mosip.certify.util.*;
import org.springframework.stereotype.Component;

import java.io.ByteArrayOutputStream;
import java.security.KeyPair;
Expand All @@ -20,6 +21,7 @@
import java.time.temporal.ChronoUnit;
import java.util.*;

@Component
public class MdocGenerator {

public static final String NAMESPACE = "org.iso.18013.5.1";
Expand Down
6 changes: 3 additions & 3 deletions ...c/main/java/io/mosip/certify/sunbirdrc/integration/service/SunbirdRCVCIssuancePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,11 @@ public VCResult<JsonLDObject> getVerifiableCredentialWithLinkedDataProof(VCReque
throw new VCIExchangeException(ErrorConstants.VCI_EXCHANGE_FAILED);
}
List<String> types = vcRequestDto.getType();
if (types.isEmpty() || !types.get(0).equals("VerifiableCredential")) {
log.error("Invalid request: first item in type is not VerifiableCredential");
if (types.isEmpty() || !types.contains("VerifiableCredential")) {
log.error("Invalid request: VerifiableCredential not present in types");
throw new VCIExchangeException(ErrorConstants.VCI_EXCHANGE_FAILED);
}
types.remove(0);
types.remove("VerifiableCredential");
String requestedCredentialType = String.join("-", types);
//Check if the key is in the supported-credential-types
if (!supportedCredentialTypes.contains(requestedCredentialType)) {
Expand Down