[IMP]website_sale_stock_ux: only show ribbon if product has no variants#438
Closed
JrAdhoc wants to merge 1 commit intoingadhoc:18.0from
Closed
[IMP]website_sale_stock_ux: only show ribbon if product has no variants#438JrAdhoc wants to merge 1 commit intoingadhoc:18.0from
JrAdhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
Este PR mejora el módulo website_sale_stock_ux para mostrar el ribbon y el blur de "Out of stock" solo cuando el producto no tiene variantes configuradas. Esto evita mostrar información engañosa en productos con múltiples variantes donde solo algunas variantes pueden estar sin stock.
- Se añade la condición
len(product.product_variant_ids) == 1tanto para el ribbon visual como para el efecto blur de imagen - Se incrementa la versión del módulo de
18.0.1.1.0a18.0.1.2.0(siguiendo la convención de bump para cambios en vistas)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website_sale_stock_ux/views/templates.xml | Agrega la verificación de cantidad de variantes a las condiciones del ribbon "Out of stock" y el efecto blur de imagen |
| website_sale_stock_ux/manifest.py | Incrementa la versión del módulo (minor bump) conforme a las mejoras realizadas en las vistas |
Contributor
|
@roboadhoc r+ |
roboadhoc
pushed a commit
that referenced
this pull request
Jan 5, 2026
closes #438 Signed-off-by: Manuela Cepeda <cem@adhoc.com.ar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.