Skip to content

[ADD] stock_ux: prevent deletion of moves linked to orders #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcadhoc wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[ADD] stock_ux: prevent deletion of moves linked to orders #873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions stock_ux/models/stock_move.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,3 +161,20 @@ def _trigger_assign(self):
if not self.env.context.get("trigger_assign"):
return super().with_context(trigger_assign=True)._trigger_assign()
return super()._trigger_assign()

@api.ondelete(at_uninstall=False)
def _unlink_if_draft_or_cancel(self):
super()._unlink_if_draft_or_cancel()
if any((move.sale_line_id or move.purchase_line_id) for move in self) and not self._context.get(
"bypass_stock_ux_protect_moves"
):
raise UserError(
_("You can not delete moves linked to sales or purchase orders, please change quantity there")
)

def _merge_moves(self, merge_into=False):
# 22/04/2024: Agregamos esto porque sino al intentar confirmar compras con usuarios sin permisos, podia pasar que salga la constrain de arriba (check_cancel)
# Agregamos bypass_stock_ux_protect_moves para permitir el unlink de moves duplicados durante el merge
return super(
StockMove, self.with_context(cancel_from_order=True, bypass_stock_ux_protect_moves=True)
)._merge_moves(merge_into=merge_into)