Skip to content

Comments

[FIX]stock_declared_value:declared value#866

Open
jcadhoc wants to merge 2 commits intoingadhoc:19.0from
adhoc-dev:19.0-18.0-h-107498-jc-3132
Open

[FIX]stock_declared_value:declared value#866
jcadhoc wants to merge 2 commits intoingadhoc:19.0from
adhoc-dev:19.0-18.0-h-107498-jc-3132

Conversation

@jcadhoc
Copy link
Contributor

@jcadhoc jcadhoc commented Feb 4, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 4, 2026 14:59
@roboadhoc
Copy link
Collaborator

Pull request status dashboard

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ajusta el cálculo del valor declarado en albaranes cuando el producto proviene de un kit (BoM phantom), corrigiendo la base de cantidades usada al explotar la BoM.

Changes:

  • Modifica la llamada a mrp.bom.explode() para explotar la BoM con cantidad unitaria (en lugar de la cantidad de la línea de venta).
  • Mantiene el cálculo de promedios para estimar el equivalente entregado/planificado del kit a partir de sus componentes.

boms, lines = bom.sudo().explode(
so_bom_line.product_id, so_bom_line.product_uom_qty, picking_type=bom.picking_type_id
)
boms, lines = bom.sudo().explode(so_bom_line.product_id, 1.0, picking_type=bom.picking_type_id)
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En esta llamada a bom.explode(...), pasar 1.0 asume implícitamente que 1 unidad está en la UoM base del producto. Si la línea de venta (so_bom_line) usa una UoM distinta, el cálculo de bom_quantity y por ende el valor declarado puede quedar incorrecto. Sugerencia: calcular la cantidad equivalente a 1 unidad en la UoM de la línea de venta (convertida a la UoM del producto/BOM) antes de explotar, o convertir el resultado para que la cantidad resultante esté en la misma UoM que el precio unitario de la línea.

Suggested change
boms, lines = bom.sudo().explode(so_bom_line.product_id, 1.0, picking_type=bom.picking_type_id)
# Calcular la cantidad equivalente a 1 unidad en la UoM de la línea de venta,
# convertida a la UoM del producto/BOM para usarla como factor de explosión.
bom_factor = 1.0
line_uom = getattr(so_bom_line, "product_uom", so_bom_line.product_id.uom_id)
product_uom = so_bom_line.product_id.uom_id
if line_uom != product_uom:
bom_factor = line_uom._compute_quantity(1.0, product_uom)
boms, lines = bom.sudo().explode(
so_bom_line.product_id,
bom_factor,
picking_type=bom.picking_type_id,
)

Copilot uses AI. Check for mistakes.
boms, lines = bom.sudo().explode(
so_bom_line.product_id, so_bom_line.product_uom_qty, picking_type=bom.picking_type_id
)
boms, lines = bom.sudo().explode(so_bom_line.product_id, 1.0, picking_type=bom.picking_type_id)
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La variable boms no se usa en ningún lado (solo se usa lines). Para evitar confusiones, elimina esa asignación o usa un placeholder (_) para el valor no utilizado.

Suggested change
boms, lines = bom.sudo().explode(so_bom_line.product_id, 1.0, picking_type=bom.picking_type_id)
_, lines = bom.sudo().explode(so_bom_line.product_id, 1.0, picking_type=bom.picking_type_id)

Copilot uses AI. Check for mistakes.
@jcadhoc jcadhoc force-pushed the 19.0-18.0-h-107498-jc-3132 branch from c5d7160 to a749ec6 Compare February 4, 2026 16:29
@mav-adhoc
Copy link
Contributor

@roboadhoc nobump

@roboadhoc
Copy link
Collaborator

Bump policy set to nobump. Modules: all

@mav-adhoc
Copy link
Contributor

@roboadhoc r+

@roboadhoc
Copy link
Collaborator

@jcadhoc @mav-adhoc because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

@mav-adhoc
Copy link
Contributor

@roboadhoc rebase-ff

@roboadhoc
Copy link
Collaborator

Merge method set to rebase and fast-forward.

@roboadhoc
Copy link
Collaborator

@jcadhoc @mav-adhoc unable to stage: commits with multiple parents (5867b92) can not be rebased, either fix the branch to remove merges or merge without rebasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants